Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4554/1/be/src/benchmarks/simple-scheduler-benchmark.cc File be/src/benchmarks/simple-scheduler-benchmark.cc: Line 130: /// according to the parameter 'replica_preference'. Mention that it uses the default # blocks? Line 147: /// Build and run a benchmark suite for various table sizes. Scheduling will be done Mention that it's done with the default cluster size? http://gerrit.cloudera.org:8080/#/c/4554/1/be/src/util/benchmark.cc File be/src/util/benchmark.cc: PS1, Line 51: by I don't think this "by" is needed -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ec1c6c1828bb0b86d1e13ce4dfc5a8df865c2e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
