Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency ......................................................................
Patch Set 11: (8 comments) thanks! http://gerrit.cloudera.org:8080/#/c/4349/11//COMMIT_MSG Commit Message: Line 11: analyzing: reference to the same table may refer to a > analyzed Done Line 12: different version, and different table may share same > the same Done Line 16: This commit removes table Id from Table object; instead > the Table Done PS11, Line 17: it > execRequest Done PS11, Line 21: references > reference Done http://gerrit.cloudera.org:8080/#/c/4349/11/fe/src/main/java/org/apache/impala/catalog/View.java File fe/src/main/java/org/apache/impala/catalog/View.java: PS11, Line 92: testig > not your change, but please fix the typo. Done. http://gerrit.cloudera.org:8080/#/c/4349/11/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 426: HashSet<Integer> seenTableId = Sets.newHashSet(); > seenTableIds Done Line 435: } > Sorry to keep adding to this, but let's also loop through all tuple descrip Done -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
