Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. ......................................................................
Patch Set 14: (4 comments) thanks http://gerrit.cloudera.org:8080/#/c/4349/14/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: Line 366 > there's a TTableDescriptor.table_id which deserves a comment (clarify that Done http://gerrit.cloudera.org:8080/#/c/4349/14/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 294: // same version of table in a single query, we cache all referenced tables here. > "of a table" Done. Yes. but I think we definitely should not cache Db at this time since we maybe expecting a "complete" table arriving. For others, I am not sure about the others. maybe we should consider those in another Jira? Line 2284: * the table has not yet been loaded in the local catalog cache. > update comment: effect on referencedTables_ Done http://gerrit.cloudera.org:8080/#/c/4349/14/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java: PS14, Line 44: Table targetTable_ > will update comment. basically this is used to reserve id 0 to table sink b Done, but may need reword? -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
