Jim Apple has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4674/2/bin/bootstrap_development.sh File bin/bootstrap_development.sh: Line 20: # This script bootstraps a development environment from almost nothing; it is known to > So, this first comment may be a nit, but it would be nice to clarify why th Let me know what else you think it needs. Line 31: HOMEDIR="/home/$(whoami)/" > This is really an artificial limitation/oversight of the chef scripts. Woul I think that's a later project, especially given that the chef scripts are not in this repo. PS2, Line 70: orLoca > 999999 was used as an arbitrarily large number in the original one-off Jenk 0 does that here, based on https://github.com/pytest-dev/pytest/blob/8639bf75549e50a74cb49d4f48d790d2c8788a87/_pytest/main.py#L560 PS2, Line 72: " > What is the difference between passing in --skiptests and then calling run- None, I think -- To view, visit http://gerrit.cloudera.org:8080/4674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If166a8a286d7559af547da39f6cc09e723f34c7e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
