Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4688/1/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 241: for (int i = 0; i < num_string_slots_; ++i) { > Not exactly the same - it still has to be called for every tuple. That's pr There is no point checking the size per row in the batch. Would rather keep it this way. -- To view, visit http://gerrit.cloudera.org:8080/4688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-HasComments: Yes
