Michael Brown has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4414/1/tests/common/kudu_test_suite.py File tests/common/kudu_test_suite.py: PS1, Line 54: def auto_create_db(cls): : return True : : @classmethod : def get_db_name(cls): : # When py.test runs with the xdist plugin, several processes are started and each : # process runs some partition of the tests. It's possible that multiple processes : # will call this method. A random value is generated so the processes won't try : # to use the same database at the same time. The value is cached so within a single : # process the same database name is always used for the class. This doesn't need to : # be thread-safe since multi-threading is never used. : if not cls.__DB_NAME > Duno. I'll check with Michael. To answer this: It looks like this provides the same functionality as unique_database, but over a different channel (the conn/cursor fixtures in conftest.py). The design of KuduTestSuite and dependents are so different than most of our test cases. While switching to unique_database can be done, it will be nontrivial, and would require a bit of a change in test design. -- To view, visit http://gerrit.cloudera.org:8080/4414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b9d51b2720ab57649abdb7d5c710ea04ff50dc1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
