Alex Behm has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4677/1/testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test File testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test: Line 5: ---- PLAN > do we need this section? or isn't this already validated somewhere else? The purpose is to validate that this plan is executable with mt_dop>0 and num_nodes=1. I don't think we test that elsewhere. Line 32: ---- DISTRIBUTEDPLAN > we don't need this section Removed. Line 121: select row_number() over(partition by int_col order by id) > have you tried to run this? I tried several values of mt_dop and this query worked fine. Line 156: from tpch_nested_parquet.customer c, c.c_orders o, o.o_lineitems > have you tried this? I tried this and other similar queries. Works fine with mt_dop=2 but crashes with higher values. Looks like a bug. Should't this query be runnable with mt_dop>0? Btw, compute stats fails with mt_dop=2, so it looks like there are still some issues. -- To view, visit http://gerrit.cloudera.org:8080/4677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91a60ea7b6e3ae4ee44be856615ddd3cd0af476d Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
