Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4274: hang in buffered-block-mgr-test ......................................................................
IMPALA-4274: hang in buffered-block-mgr-test We started seeing hangs in CreateDestroyMulti() where a thread was recursively acquiring static_block_mgrs_lock_. This is only possible because a shared_ptr is destroyed while holding the lock. The fix is to reset the shared_ptr only after releasing the lock. Testing: I was unable to reproduce the hang locally, but the callstack in the JIRA was a strong enough smoking gun to feel confident that this should fix the hang. Change-Id: I21f3da1d09cdd101a28ee850f46f24acd361b604 Reviewed-on: http://gerrit.cloudera.org:8080/4690 Reviewed-by: Alex Behm <[email protected]> Reviewed-by: Marcel Kornacker <[email protected]> Tested-by: Internal Jenkins --- M be/src/runtime/buffered-block-mgr.cc 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Marcel Kornacker: Looks good to me, approved Internal Jenkins: Verified Alex Behm: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/4690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f3da1d09cdd101a28ee850f46f24acd361b604 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]>
