Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4519/9/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 116: "to a thread pool to finish setup, reducing the chances that connections time out " > what's the rationale for making this optional and leaving the old logic in While we're confident in this implementation, it's not a bad idea to have a get-out-of-jail flag until we've seen it be successful in real-world deployments. This only controls which kind of object gets created, so keeping it doesn't add much complexity over removing it. -- To view, visit http://gerrit.cloudera.org:8080/4519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie50e728974ef31a9d49132a0b3f7cde2a4f3356d Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
