Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. ......................................................................
Patch Set 6: Code-Review+1 (2 comments) Thanks! LGTM, just a few comments for the commit msg. I didn't look at the codegen code changes in detail. http://gerrit.cloudera.org:8080/#/c/4673/6//COMMIT_MSG Commit Message: Line 9: The main motivation of this change is to pave the way for full There are 2 main motivations of this change, no? 1) More compact memory layout. 2) Zero copy (or at least avoiding conversions) with Kudu scans... (as you already have here) Line 12: that goal. Can you mention what is left after this? My understanding is that it is (correct me if I'm wrong): 1) planner needs to set null flags for nullable columns 2) kudu scan node can now _copy_ mem, i.e. rip out conversion code 2) kudu client needs to support mem xfer 3) kudu scan node updated to use mem xfer instead of copying (KUDU-1695) -- To view, visit http://gerrit.cloudera.org:8080/4673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6510c75d841bddafa6638f1bd2ac6731a7053f6 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
