Tim Armstrong has posted comments on this change.

Change subject: Reduce LLVM module's preparation time by lazily creating the 
IRFunction::Type to LLVM::Function* mappings.
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4691/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 209:     StringRef fn_name(FN_MAPPINGS[i].fn_name);
> Or if the in memory copy of the bitcode is corrupted somehow. That said, it
We're in real trouble if embedded data in the binary is corrupted anyway.


http://gerrit.cloudera.org:8080/#/c/4691/2/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 209:     StringRef fn_name(FN_MAPPINGS[i].fn_name);
This StringRef conversion is redundant, can just inline FN_MAPPING[i].fn_name 
below.


PS2, Line 403: StringRef
This StringRef() is also redundant.


Line 664:     StringRef fn_name(FN_MAPPINGS[ir_type].fn_name);
This StringRef() conversion is also redundant.


-- 
To view, visit http://gerrit.cloudera.org:8080/4691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61ab9fa8cca5a0909bb716c3c62819da3e3b3041
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to