Alex Behm has posted comments on this change.

Change subject: IMPALA-4259: build Impala without any test cluster setup.
......................................................................


Patch Set 5:

(2 comments)

So much better

http://gerrit.cloudera.org:8080/#/c/4685/5/buildall.sh
File buildall.sh:

Line 263:   NEED_TEST_CLUSTER=1
NEED_MINICLUSTER?


Line 316:   pushd "${IMPALA_FE_DIR}"
I'm a little confused by having a "fe" cmake target that we are using in 
build_fe() but not here. Looks like building the fe with make would take care 
of building its dependencies also, so maybe we can simplify the flow here?


-- 
To view, visit http://gerrit.cloudera.org:8080/4685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to