Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3002/1473: Cardinality observability cleanup ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4679/1/tests/query_test/test_exec_summary.py File tests/query_test/test_exec_summary.py: PS1, Line 27: : : : : : : : : : : : : : : : : : : : : : : > Thanks for adding a test. However, there's already logic to parse the summa Done PS1, Line 57: : : : : > There are 'execute' versions that handle waiting and closing for you. Take Done PS1, Line 64: : : : : : : : > you should be able to avoid the string parsing yourself and use the structu Done -- To view, visit http://gerrit.cloudera.org:8080/4679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I386719370386c9cff09b8b35d15dc712dc6480aa Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
