Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4289: Mark agg slots of NDV() functions as non-nullable. ......................................................................
IMPALA-4289: Mark agg slots of NDV() functions as non-nullable. This change might give a minor speedup to COMPUTE STATS and COMPUTE INCREMENTAL STATS. In any case, marking the slots non-nullable seems strictly better than leaving them nullable. Testing: I ran our local testdata/compute-table-stats.sh and it succeeded. Change-Id: I1c05b8dfb797b2a42ee1a7bf14ad56bb83d2b1c5 Reviewed-on: http://gerrit.cloudera.org:8080/4707 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AggregateInfoBase.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/4707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c05b8dfb797b2a42ee1a7bf14ad56bb83d2b1c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
