Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3718: Add test_cancellation tests for Kudu
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4700/1/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

Line 94:           pytest.skip()
> What happens if we don't skip this? Are those edge cases potentially intere
We'll skip a few of the queries for Kudu, e.g. the one  with 'select 
count(l_returnflag)', but I don't think it's that concerning since these tests 
are going to exercise the cancellation of a kudu table sink and I don't think 
it matters too much if there was an agg in there as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/4700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3d3853e7075991f6d12f125407ebdbe6a287e2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to