Jim Apple has posted comments on this change.

Change subject: Match .clang-format more closely to actual practice.
......................................................................


Patch Set 4:

> When did we decide that the change in the comment was one we
 > wanted? For one, I prefer having args on one line where possible.

The change the commit comment? That was suggested by Marcel to me in a private 
email. I didn't question it, as it seemed to me this matched the way the code 
is currently styled. For better or worse, I couldn't get clang-format to 
actually follow that style, so we're stuck with (or "stuck with") the style you 
prefer.

-- 
To view, visit http://gerrit.cloudera.org:8080/4590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: No

Reply via email to