Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4294: Execute data load steps from within git repo. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.sh: PS2, Line 431: # Data loading relies upon comparing git hashes, so we need to make sure : # we're executing from within the context of the Impala repo directory. : pushd "${IMPALA_HOME}" : load_test_data : popd Do you think it would make more sense to pushd in Impala/testdata/bin/check-schema-diff.sh, because it will be closer to where it's actually needed? Also it would make that script more robust. -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
