Dan Hecht has posted comments on this change. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4668/1/be/src/runtime/client-cache.cc File be/src/runtime/client-cache.cc: PS1, Line 95: // Only need to decrement it here. the "if succeeded" explains this, so you could remove this sentence, which I think is a bit confusing (not clear what "here" means -- this function, this if-stmt, etc?). -- To view, visit http://gerrit.cloudera.org:8080/4668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
