Henry Robinson has posted comments on this change.

Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................


Patch Set 1:

(2 comments)

This will be useful to have.

http://gerrit.cloudera.org:8080/#/c/4588/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

PS1, Line 88: WARNING
Let's not use such a generic key. How about "Debug Mode Warning" ?


PS1, Line 88: "WARNING", "This profile has been created by a DEBUG build. If "
            :       "you are looking for performance related information, we 
suggest to use a RELEASE "
            :       "build instead."
Just a suggestion to make it snappier:

"Query profile created while running a DEBUG build of Impala. Use RELEASE 
builds to measure query performance."


-- 
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to