Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/4047/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: PS6, Line 734: RESULT = new InsertStmt(w, table, false, null, null, query, null, false, true); :} nit: can you add some newlines to make this spaced like the case above? http://gerrit.cloudera.org:8080/#/c/4047/6/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: PS6, Line 75: all non-partition columns in Hive : // order. doesn't quite make sense for the Kudu code. Can you indicate how it's handled in that case? PS6, Line 342: setTargetTable This does more than sets the table. analyzeTargetTable() would be more accurate. http://gerrit.cloudera.org:8080/#/c/4047/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: PS6, Line 869: ParsesOk("with t as (select 1) upsert into x with t as (select 2) select * from t"); : ParsesOk("with t(c1) as (select 1) " + : "upsert into x with t(c2) as (select 2) select * from t"); This removes the insert test cases, I assume you didn't mean to change these lines http://gerrit.cloudera.org:8080/#/c/4047/6/testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test File testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test: PS6, Line 272: VARCHAR(20)), false), : (1, 'known', 1, 0, cast('a' as VARCHAR why varchars? -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df5cea36b642e267f85ff6b163f3dd96b8386e9 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
