Henry Robinson has posted comments on this change. Change subject: Remove Llama dependency ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json File common/thrift/metrics.json: PS1, Line 573: : : : : : : : : : : : : : : : : : : > I don't have any way to easily test it. These metrics no longer exist so I Looks like we (I) have removed metrics pretty recently anyhow. I couldn't remember whether this file constituted any kind of public interface that we couldn't remove things from. You should be good to go. -- To view, visit http://gerrit.cloudera.org:8080/4739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
