Marcel Kornacker has posted comments on this change. Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4745/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: Line 121: private boolean hasClusteredHint_ = false; might be better to use ternary logic here with a single Boolean (which can be null) Line 631: if (hasNoShuffleHint_) { did you mean noclustered? Line 632: throw new AnalysisException("Conflicting INSERT hint: " + hint); list both conflicting hints (otherwise it's hard to tell how to fix the problem, other than dropping the hint). also fix the other error messages. http://gerrit.cloudera.org:8080/#/c/4745/1/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: Line 68: * sorted. Its source exprs are update to those in tupleSlotExprs. second sentence incomprehensible. Line 123: * the exprs used by the SortNode refer to the materialized tuples instead of the don't refer to the sort node here, SortInfo shouldn't have to know about that http://gerrit.cloudera.org:8080/#/c/4745/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 275: public PlanFragment addClusteringFragment(PlanFragment inputFragment, you should move the logic (minus the createSortTupleInfo part that alex brought up) into createInsertFragment -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
