Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION ......................................................................
Patch Set 14: (3 comments) > Attila, any updates on this one? Let me know if you need any help > with the tests? Sorry for the late response, I was on PTO for a week. Uploading the new change-set now. http://gerrit.cloudera.org:8080/#/c/4144/14/fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java: PS14, Line 211: new Comparator<PartitionKeyValue>() { : @Override : public int compare(PartitionKeyValue t, PartitionKeyValue o) { : return t.getColName().compareTo(o.getColName()); : } > Thanks for the explanation. Can you please consider moving this comparison Moved it to PartitionKeyVale.getColNameComparator() http://gerrit.cloudera.org:8080/#/c/4144/14/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: PS14, Line 714: # Sometimes metadata load is triggered here, so compare only the first three : # returned partitions. > I am sorry but we can't just leave it like this. a) we need to understand i The non-deterministic behavior was caused by the SYNC_DDL query option, which is set to 1 in the previous tests (in ImpalaDbWrapper.__exit__()). Setting SYNC_DDL to 0 in ImpalaDbWrapper.__enter__() fixed the issue. PS14, Line 770: def test_partitions_exist_after_refresh(self, vector): > I don't think this is an integration test. You may want to move it to test_ This test and the INVALIDATE METADATA case was moved to alter-table.test (L1059-L1132). -- To view, visit http://gerrit.cloudera.org:8080/4144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbc951f2931f488f7048c9780260f6b49100750 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
