Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables ......................................................................
Patch Set 5: (4 comments) A few minor clarifications. http://gerrit.cloudera.org:8080/#/c/4414/5/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: Line 195: msClient.alter_table(msTable_.getDbName(), msTable_.getTableName(), msTable_); > Right, most of the time there will be no changes. I'm not only worried abou In theory, it should be ok given that there is a single write path to HMS for Kudu table schema. If that changes, I agree we may have to deal with some weird inconsistent states. Line 216: String colName = ToSqlUtils.getIdentSql(colSchema.getName()); > We don't parse the column names in the HMS backend table and neither does H Yeah, you're right. Fixed it in a follow up patch. http://gerrit.cloudera.org:8080/#/c/4414/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 1151: // the metadata must be fetched from the Hive Metastore. > Makes sense now that you've explained, please leave a brief comment. Done http://gerrit.cloudera.org:8080/#/c/4414/5/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: Line 85: kudu.createTable(kuduTableName, schema, tableOpts); > Agree. Can you file a JIRA against Kudu? Thanks! Done -- To view, visit http://gerrit.cloudera.org:8080/4414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b9d51b2720ab57649abdb7d5c710ea04ff50dc1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
