Alex Behm has posted comments on this change.

Change subject: IMPALA-4155: Update default partition when table is altered

Patch Set 2:

Commit Message:

Line 9: If the table format is changed by the Alter Table statement, the
Also mention that the insert picks up the file format for new partitions from 
that default partition.

Line 10: default partition in a partitioned tables does not get updated. This
"in partitioned tables used to not get updated."
File fe/src/main/java/org/apache/impala/catalog/

Line 971:     // refer to this to understand how to create new partitions. If 
this method is called
This new sentence should go into the method comment above. something like "Adds 
or replaces the default partition"
File fe/src/main/java/org/apache/impala/service/

Line 1872:       // The default partition must be updated if the file format is 
brief explanation why, e.g., "so that new partitions are created with the new 
file format"

Line 1917:       if (tbl instanceof HdfsTable) ((HdfsTable) 
brief explanation why such as "Update default partition so that new partitions 
are created under the new location"
File testdata/workloads/functional-query/queries/QueryTest/alter-table.test:

Line 961: drop table if exists i3802_alter;
No need for this drop if exists because we're using unique_database in the 
pytest. Can you also remove it in the few tests above? Thanks

Line 962: create table i3802_alter (c1 int)
fix jira#

Line 970: INT, STRING
add another test for altering the location and check that the existing 
partition keeps its old location, but a new partition is added under the new 

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I59bf21caa5c5e7867d07d87cda0c0a5b4b994859
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-HasComments: Yes

Reply via email to