Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate ......................................................................
Patch Set 1: (1 comment) Thanks for finding and fixing this! Let me know if you have trouble with adding a test and I'll help. http://gerrit.cloudera.org:8080/#/c/4753/1/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 1164: CompoundPredicate compoundPredicate = Can you add a short planner test for this? See PlannerTest.java. Maybe add it to subquery-rewrite.test Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79bfc67605206e0e026293bf7032a88227a95623 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
