Henry Robinson has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4768/1/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS1, Line 623: child_queries remind me why we don't put line 616->622 in this kind of conditional? ISTR there was a reason we wanted to run child_query_executor_->WaitForAll() in all cases, but it escapes me now. -- To view, visit http://gerrit.cloudera.org:8080/4768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3881d032622750444d750f161ad6843bdbd16c30 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
