Lars Volker has posted comments on this change. Change subject: Minor fixes to remove more "cloudera"s from the code. ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4774/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: Line 249: url = 'https://api.github.com/repos/apache/incubator-impala/commits/' + commit_sha > I don't think that commit is in the upstream repo. Try this: Yes, it seems that commits that land in both repos end up having different hashes. Since the hash passed here is extracted from a profile, anyone who uses this would need to build from the incubator repo instead of cloudera/impala, so that the commit from the profile can be found. Let's update it and send a mail to dev@ afterwards to let everyone know. -- To view, visit http://gerrit.cloudera.org:8080/4774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27687a3b677def72f1867df54c8e50c93d5cab3a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
