Henry Robinson has posted comments on this change. Change subject: IMPALA-4335: Don't send 0-row batches to sink ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4787/2/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: Line 88: // Don't enter the loop if batch->num_rows() == 0; no point triggering the consumer with > This sounds rather benign. Mention that some clients may not handle empty b It's benign, but it's true: we don't want to trigger the consumer (why pay a context switch to do no work and force another RPC?). -- To view, visit http://gerrit.cloudera.org:8080/4787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d339c1f9a55d9d75fb0e97d16b3176cc34f2171 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
