Michael Ho has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4740/3/be/src/exec/analytic-eval-node.cc File be/src/exec/analytic-eval-node.cc: Line 403: } > so this bug was similar to IMPALA-3311 (see PartitionedAggregationNode::Han Yes. We need some refactoring to share the code. Probably not worth it. Line 420: (next_partition || (fn_scope_ == RANGE && window_.__isset.window_end && > this indentation seems off. what does clang-format say? Tried with clang-format but still looks a bit odd. Changed the indentation to look closer to the existing code. http://gerrit.cloudera.org:8080/#/c/4740/3/be/src/exprs/agg-fn-evaluator.h File be/src/exprs/agg-fn-evaluator.h: PS3, Line 153: beyond the scope of the call site > Maybe say "The memory is a local allocation and so needs to be copied out b Incorporated comments from Dan and Matt. PS3, Line 153: beyond the scope of the call site > I'm still not sure this is precise enough... this sounds like it's scoped a Done -- To view, visit http://gerrit.cloudera.org:8080/4740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85bb1745232d8dd383a6047c86019c6378ab571f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
