Tim Armstrong has posted comments on this change. Change subject: Add distcc infrastructure. ......................................................................
Patch Set 1: (6 comments) Thanks for doing this http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh File bin/distcc/distcc.sh: Line 1: #!/bin/bash Needs a copyright header Line 34: clang) # Assume the compilation options were setup for gcc, which would happen using Ugh, we really should just consolidate the GCC/Clang argument handling into one place in the CMake scripts instead of adding this layer of hacks. Anyway, don't need to fix now. Line 46: PATH="$DISTCC_ENV_DIR:$PATH" Should be able to get rid of this, we don't pick the linker up from PATH now anyway. http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc_env.sh File bin/distcc/distcc_env.sh: Line 1: # This file is intended to be sourced by a shell (zsh and bash have been tested). Needs a copyright header PS1, Line 44: BUILD_FARM Can you check if BUILD_FARM is defined and print a message? Otherwise people may be confused if they run it and it breaks. Line 131: function switch_linker { All this linker stuff is irrelevant now that we're using the toolchain linker. Let's just delete it. -- To view, visit http://gerrit.cloudera.org:8080/4820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4bc78ad46dda13e4533183195af632f46377cae Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
