Tim Armstrong has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool ......................................................................
Patch Set 6: Code-Review+1 (1 comment) Would give a +2 except I think it'd be good to have someone else look at the AlignedNew abstraction - it makes sense to me but I think is somewhat of a new pattern. The rest seems uncontroversial. http://gerrit.cloudera.org:8080/#/c/4758/6/cmake_modules/clang_toolchain.cmake File cmake_modules/clang_toolchain.cmake: Thank you! This makes more sense. -- To view, visit http://gerrit.cloudera.org:8080/4758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed168488cb30ddeccd0087f3840541d858f9c06 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
