Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements ......................................................................
Patch Set 9: (6 comments) Thanks for the comments, please see PS9. http://gerrit.cloudera.org:8080/#/c/4745/5/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: Line 602: } > Thanks. The reason why it works without is that SortNode.init() during plan Ok Line 604: if (matchFound && table_ instanceof KuduTable) { > I vote for keep Ok http://gerrit.cloudera.org:8080/#/c/4745/8/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: Line 603: // Store exprs for Kudu key columns. > add line breaks between if blocks, it's harder to navigate without those (' Done http://gerrit.cloudera.org:8080/#/c/4745/8/fe/src/main/java/org/apache/impala/analysis/QueryStmt.java File fe/src/main/java/org/apache/impala/analysis/QueryStmt.java: Line 237: * outputs of aggregation. > something missing there. (i know, not your fault.) Yes, I couldn't figure out in git blame what that sentence originally meant. Since I don't understand enough of the code to complete it, I removed it. Let me know if I should replace it with something else. http://gerrit.cloudera.org:8080/#/c/4745/8/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test: Line 247: # IMPALA-2521: clustered insert into table adds sort node, correctly substituting exprs. > you can't always see the correct substitution until you run the query (beca Done Line 249: select id, name, maxzip as zip > use fewer columns, add an analytic function in the inline view Done -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412153bd8435d792bd61dea268d7a3b884048f14 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
