Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. ......................................................................
Patch Set 16: (10 comments) Thanks Marcel. http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 294: // The Impalad Catalog has the latest tables from the statestore. In order to use the > add todo that we need to investigate whether to do this for other catalog o Done http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java File fe/src/main/java/org/apache/impala/analysis/DescriptorTable.java: Line 43: * them unique ids. > "may be null" is a better phrasing. Done Line 44: */ > "Set in QueryStmt.analyze()." Done Line 45: public class DescriptorTable { > remove last sentence, that goes without saying. Done Line 179: // inline view of a non-constant select has a non-materialized tuple descriptor > "checking that" Done Line 180: // in the descriptor table just for type checking, which we need to skip > "same Table instance" is even more specific (because we're talking about ob Done Line 202: for (SlotDescriptor slotD: tupleDesc.getMaterializedSlots()) { > single line Done http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java: Line 201: public void materializeSlots() { > single line done. but not sure if this is what you meant. http://gerrit.cloudera.org:8080/#/c/4349/15/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 438: if (descTbl.isSetTupleDescriptors()) { > precede w/ blank line Done Line 447: if (execRequest.isSetFragments() && !execRequest.fragments.isEmpty()) { > same here Done -- To view, visit http://gerrit.cloudera.org:8080/4349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2 Gerrit-PatchSet: 16 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
