Tim Armstrong has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache ......................................................................
Patch Set 1: (1 comment) The change makes sense and we should get it in regardless, but could this have caused the original crash we saw? http://gerrit.cloudera.org:8080/#/c/4828/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 445 This is definitely suspicious. Sometimes I feel like some of the DCHECKS were expressions of hope rather than assertions. -- To view, visit http://gerrit.cloudera.org:8080/4828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
