Michael Brown has posted comments on this change. Change subject: IMPALA-3872: allow providing PyPi mirror for python packages ......................................................................
Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/4770/2/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: PS2, Line 73: return True > This doesn't work for me - if I have PYPI_MIRROR = "https://pypi.infra.clou Too bad. I think the URL python libraries are needlessly complicated. http://gerrit.cloudera.org:8080/#/c/4770/3/infra/python/deps/pip_download.py File infra/python/deps/pip_download.py: PS3, Line 31: from urlparse import urljoin Remove -- To view, visit http://gerrit.cloudera.org:8080/4770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc11f010332c0225121c86c9930e35c7ac01409c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
