Tim Armstrong has posted comments on this change. Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4813/5/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: PS5, Line 166: i < simd_size; See IMPALA-4381 - the index computations here seem wrong now - it's not clear whether i/simd_size are denominated in sizeof(double) or sizeof(__m256d). I have a suspicion the bug is here. We should probably use the same convention as below where i/simd_size are denominated in sizeof(__m256d). -- To view, visit http://gerrit.cloudera.org:8080/4813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I840799d9cfb81285c796e2abfe2029bb869b0f67 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
