Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4374: Use new syntax for creating TPC-DS/H tables in Kudu stress test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4860/1/testdata/datasets/tpcds/tpcds_kudu_template.sql File testdata/datasets/tpcds/tpcds_kudu_template.sql: PS1, Line 34: TBLPROPERTIES ('kudu.master_addresses' = '{kudu_master}:7051') > can we assume the impala cluster has the default kudu master set correctly Hm, I think it may be better to leave it as is for now. I am afraid that, until CM adds support for setting it, we may launch a cluster that isn't configured properly. Today we infer the kudu master from the specified cluster nodes (assume it's the first) and then pass this param to all the scripts that need it, including this one. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/4860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d501fb9c3cba00b1fb0f7b5941db49cbbda5a53 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
