Tim Armstrong has posted comments on this change. Change subject: IMPALA-4381: Incorrect AVX version of BloomFilter::Or ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4866/1/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: PS1, Line 165: ; in != in_end; (in + > I think it is clearer. The relative precedences of += and , are not somethi , is a statement separator rather than an operator so it seems clear enough, but I don't feel strongly. http://gerrit.cloudera.org:8080/#/c/4866/2/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: PS2, Line 183: DCHECK DCHECK_EQ -- To view, visit http://gerrit.cloudera.org:8080/4866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18480c598fbf6b842398581acde6fc719c40ce27 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
