Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4314: Standardize on MT-related data structures ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4853/2/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: PS2, Line 113: Verifies that the schedule is well-formed: : /// - all fragments have a FragmentExecParams : /// - all scan ranges are assigned > What's the behaviour if it's not valid? Presumably DCHECK, but should menti missed that, but i'll add the comment before checking it in. -- To view, visit http://gerrit.cloudera.org:8080/4853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I465d0e15e2cf17cafe4c747d34c8f595d3645151 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
