Dan Hecht has posted comments on this change. Change subject: IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4865/1/be/src/exec/plan-root-sink.cc File be/src/exec/plan-root-sink.cc: Line 156: if (consumer_done_) return state->CheckQueryState(); > sure, fine to leave out now, but please change in a follow-up patch. For me, it's less comprehensible to have this check because it is racy -- the lock is dropped at line 163 -- and so consumer_done_ can get set in the middle of this routine anyway. We can keep the consumer_done_ check on line 162 to deal with that, but then we have two possible tear-down sequences rather than one (one where we notice sender_done_ is set and the other when we notice consumer_done_ is set), so to me that harder to reason about (and get test coverage for both). -- To view, visit http://gerrit.cloudera.org:8080/4865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4e25c1d658b3929182ba5e56b5c5e881dd394a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
