Alex Behm has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions ......................................................................
Patch Set 2: (10 comments) Had a pass over the tests. http://gerrit.cloudera.org:8080/#/c/4856/2/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: Line 117: * Builds and returns a range partition bound to be used in the creation of a Kudu remove "to be" to disambiguate ("bound" could be a interpreted as noun or "bound to be" as a verb") also use "range-partition bound" Line 167: TExprNode literal = boundaryVal.getNodes().get(0); check state that boundaryVal is a literal expr http://gerrit.cloudera.org:8080/#/c/4856/2/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: Line 1632: //TestUtils.assumeKuduIsSupported(); I know why this is here :) Line 2386: ParserError("CREATE TABLE Foo (i int) DISTRIBUTE BY RANGE(i) SPLIT ROWS ((1),(2))"); remove (there many things we don't support) Line 2408: ParserError("CREATE TABLE Foo (a int) DISTRIBUTE BY RANGE (a) ()"); Test that something like >= does not parse. We might consider parsing all comparison ops and giving a nicer error message during analysis. You can think about it. Line 2419: ParserError("CREATE TABLE Foo (a int) DISTRIBUTE BY RANGE (a) " + add tests with PARTITION 1 < VALUE and PARTITION VALUES = 10 (mismatched comparison op and VALUE/VALUES) Line 2561: ParsesOk("CREATE TABLE Foo PRIMARY KEY (a, b) DISTRIBUTE BY HASH (b) INTO 2 " + add one CTAS test with RANGE and some PARTITIONs http://gerrit.cloudera.org:8080/#/c/4856/2/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: Line 91: (partitiion values <= 1, partition 1 < value <= 10, partition 10 < values) stored as kudu; typo: partitiion http://gerrit.cloudera.org:8080/#/c/4856/2/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test: Line 68: (partition values <= 10, partition 10 < values <=20, partition 20 < values <= 30, nit: space after second <= Line 127: primary key (id, name)) distribute by hash(id) into 4 buckets, range(id, name) is there a limit on the number of range partitions? -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6799c01a37003f0f4c068d911a13e3f060110a06 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
