Lars Volker has posted comments on this change. Change subject: IMPALA-4387: validate decimal type in Avro file schema ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4876/2//COMMIT_MSG Commit Message: PS2, Line 16: scans nit: wrap at 80 chars. http://gerrit.cloudera.org:8080/#/c/4876/2/be/src/util/avro-util.cc File be/src/util/avro-util.cc: Line 109: case AVRO_BYTES: maybe add a // fallthrough comment at the end of the line? Line 139: return Status::OK(); Wouldn't it be better to return a non-OK status in a release build? If not, can you add a comment explaining why / what the consequences are? http://gerrit.cloudera.org:8080/#/c/4876/2/be/src/util/avro-util.h File be/src/util/avro-util.h: PS2, Line 84: name column_name? -- To view, visit http://gerrit.cloudera.org:8080/4876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a326ee2220bc14d3b5f887dc288b4adf859cfc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
