Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4862/6/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: Line 145: public boolean isKuduScanSlot() { return getColumn() instanceof KuduColumn; } this assumes isScanSlot(). either checkstate that or test for it and return a null otherwise. http://gerrit.cloudera.org:8080/#/c/4862/6/fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java File fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java: Line 62: * Null flags are omitted for non-nullable slots, except for Kudu scan slots which always what was the reason for not simplifying this and always having null flags for everything? -- To view, visit http://gerrit.cloudera.org:8080/4862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
