Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4895/1/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS1, Line 537: session_->kudu_latest_observed_ts = std::max<uint64_t>( : session_->kudu_latest_observed_ts, latest_kudu_ts); Just a suggestion, if we make this a CAS loop, we can avoid taking the session lock, as that looks like a highly contended lock. Also, since this is on teardown, the performance impact shouldn't matter as much. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/4895 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
