Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4873/2/tests/comparison/common.py File tests/comparison/common.py: PS2, Line 527: updatable_columns it might be more helpful to use an existing concept, e.g. 'non_pk_cols' or something like that http://gerrit.cloudera.org:8080/#/c/4873/2/tests/comparison/db_connection.py File tests/comparison/db_connection.py: PS2, Line 537: () ? PS2, Line 695: PRIMARY KEY (pk1, pk2) can you comment if this is the same format printed for 1 PK col as well? http://gerrit.cloudera.org:8080/#/c/4873/2/tests/conftest.py File tests/conftest.py: Line 456: generator, stress test, etc. but why is this necessary? -- To view, visit http://gerrit.cloudera.org:8080/4873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Harrison Sheinblatt <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
