Jim Apple has posted comments on this change. Change subject: IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4918/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir long line Line 14: results directory within tests/. We shoud not be polluting the tests/ dir long line Line 19: logs/, and nothing was created in tests/. Did you look around to see if anything else was depending on run-process-failure-tests.sh to write some files to the results directory within tests? What calls rpft.sh? http://gerrit.cloudera.org:8080/#/c/4918/1/tests/run-process-failure-tests.sh File tests/run-process-failure-tests.sh: PS1, Line 28: /results Is this part just extra noise? Line 29: mkdir -p ${RESULTS_DIR} Can you liberally sprinkle some double quotes around, in case IMPALA_HOME has spaces in it? -- To view, visit http://gerrit.cloudera.org:8080/4918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-HasComments: Yes
