Alex Behm has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions ......................................................................
Patch Set 4: (1 comment) I'm happy with this change pending the remaining casting investigation. http://gerrit.cloudera.org:8080/#/c/4856/3/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: PS3, Line 82: create table tab (a int primary key) distributed by range (a) (partition value = false) : stored as kudu : ---- CATCH : ImpalaRuntimeException: Expected 'int32' literal for column 'a' got 'BOOLEAN' > Well the checks in the analysis allow this case because boolean is implicit Sounds cleaner to me cast the literals to the appropriate type, but I can imagine that this might cause an unpleasant reorg of the current folding and type checking code. Maybe you can look into how hard it is to fix and we can re-evaluate? -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6799c01a37003f0f4c068d911a13e3f060110a06 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
