Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input ......................................................................
Patch Set 5: (4 comments) Thanks for the review, please see PS6. http://gerrit.cloudera.org:8080/#/c/4863/5/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 277: if (new_file) { > Can avoid a level of nesting with if (!new_file) break; Done Line 294: current_row_ = batch->GetRow(i); > Oh man, I didn't notice this 'current_row_' thing earlier. It looks like fo Done Line 302: RETURN_IF_ERROR(WriteRowsToPartition(state, batch, current_partition_pair)); > I think we should also remove the entry in partition_keys_to_output_partiti Done http://gerrit.cloudera.org:8080/#/c/4863/4/tests/query_test/test_insert_behaviour.py File tests/query_test/test_insert_behaviour.py: Line 476: > Maybe a little much given core already takes too long - I think it's useful Done -- To view, visit http://gerrit.cloudera.org:8080/4863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeda0bdabbfe44c8ac95bf7c982a75649e1b82d0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
