Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4427: leopard: make DOCKER_IMAGE_NAME required ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4936/1/tests/comparison/leopard/controller.py File tests/comparison/leopard/controller.py: Line 48: Was this extra line intentional? http://gerrit.cloudera.org:8080/#/c/4936/1/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS1, Line 106: os.environ.get Why is this different from the indexing above? I'm guessing this fails if the key doesn't exist? If so, please just add brief comment. -- To view, visit http://gerrit.cloudera.org:8080/4936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1cb96cb5c9a894f40e0892f3bdd3f3d0158e887 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
